Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark noarch/blackd-19.10b0-2.tar.bz2 as broken #101

Merged
merged 3 commits into from
Jul 23, 2020
Merged

mark noarch/blackd-19.10b0-2.tar.bz2 as broken #101

merged 3 commits into from
Jul 23, 2020

Conversation

carlodri
Copy link
Contributor

@carlodri carlodri commented Jul 23, 2020

it depends on noarch/black-19.10b0-2.tar.bz2 which is itself broken

relevant issue/PR: conda-forge/black-feedstock#13 and conda-forge/black-feedstock#12

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

it depends on noarch/black-19.10b0-2.tar.bz2 which is itself broken
@carlodri carlodri requested a review from a team as a code owner July 23, 2020 10:30
@carlodri
Copy link
Contributor Author

cc @conda-forge/black

@mbargull
Copy link
Member

Instead of changing example.txt please add a new file.

@carlodri
Copy link
Contributor Author

Instead of changing example.txt please add a new file.

sorry...fixed it now!

@mbargull
Copy link
Member

Thanks!

@mbargull mbargull merged commit c550c7b into conda-forge:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants